Draft: Do not review, add support for specific geometry types #2803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panbhag-ch
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2803 +/- ##
==========================================
- Coverage 51.67% 51.52% -0.16%
==========================================
Files 184 184
Lines 27777 27882 +105
==========================================
+ Hits 14355 14366 +11
- Misses 11786 11882 +96
+ Partials 1636 1634 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
serprex
reviewed
Apr 7, 2025
| // Check the column type name to determine specific geometry type | ||
| colType := strings.ToLower(string(field.Name)) | ||
| switch { | ||
| case strings.Contains(colType, "point"): |
There was a problem hiding this comment.
field.Name is column's name, not column's type. We don't have enough information here to figure it out. May need to make geometry all fall under one QValueKind & put SRID as a field for QValueGeometry
| case "geometry", "point", "polygon", "linestring", "multipoint", "multipolygon", "geomcollection": | ||
| return qvalue.QValueKindGeometry, nil | ||
| case "geometry", "point", "linestring", "polygon", "multipoint", "multilinestring", "multipolygon", "geometrycollection": | ||
| switch ct { |
There was a problem hiding this comment.
Earlier check is on strings.ToLower(ct) this check is on ct,
maybe we should instead merge with parent switch?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.